forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deep and universal links #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
commented
Apr 9, 2024
okwasniewski
force-pushed
the
pr/139
branch
2 times, most recently
from
April 10, 2024 08:32
62751d1
to
f21197d
Compare
okwasniewski
added a commit
that referenced
this pull request
Apr 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Apr 30, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
May 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
May 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Aug 5, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Aug 26, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Aug 26, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
okwasniewski
added a commit
that referenced
this pull request
Sep 16, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
okwasniewski
added a commit
that referenced
this pull request
Sep 16, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
okwasniewski
added a commit
that referenced
this pull request
Sep 17, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
okwasniewski
added a commit
that referenced
this pull request
Sep 17, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
okwasniewski
added a commit
that referenced
this pull request
Sep 24, 2024
* feat: add multi-window support * feat: introduce WindowManager fix: RCTReactViewController properly check props to update fix: use clearColor instead of systemBackgroundColor for visionOS (#125) feat: allow to use WindowHandlingModifier outside of RCTMainWindow fix: deep and universal links when app is running (#140) Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com> fix: remove window init feat: add support for ornaments & dev menu trigger (#149) * feat: add support for ornaments * feat: add ornaments support to second window fix: allow to manually move dev menu to avoid conflicts (#150) fix: remove unnecessary diff after upstreaming changes (#151) Make CMake 3.29.0 as minimum required version (#155) fix: move visionOS codegen specs, sync with upstream chore: sync with upstream fix: remove template Move template to a separate repo fix: update oot-release scripts chore: remove unnecessary diff (#159) fix: react-native-config chore: sync with upstream chore: sync with upstrteam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR allows to use deeplinks/universal links in React Native visionOS apps.
In order to use this feature, users need to add this modifier to their App.swift file:
A more in-depth documentation page will be created.
Thanks to @thiagobrez for investigating this one and helping me with the implementation and testing 🙏
Changelog:
[VISIONOS] [ADDED] - Support for deep links / universal links
Test Plan:
Check if deeplink is opening the app