Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep and universal links #140

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: deep and universal links #140

merged 1 commit into from
Apr 10, 2024

Conversation

okwasniewski
Copy link
Member

@okwasniewski okwasniewski commented Apr 9, 2024

Summary:

This PR allows to use deeplinks/universal links in React Native visionOS apps.

In order to use this feature, users need to add this modifier to their App.swift file:

@main
struct RNTesterApp: App {
  @UIApplicationDelegateAdaptor var delegate: AppDelegate
  
  var body: some Scene {
    RCTMainWindow(moduleName: "RNTesterApp")
      .onOpenURL(perform: { url in
        RCTLinkingManager.onOpenURL(url: url)
      })
  }
}

A more in-depth documentation page will be created.

Thanks to @thiagobrez for investigating this one and helping me with the implementation and testing 🙏

Changelog:

[VISIONOS] [ADDED] - Support for deep links / universal links

Test Plan:

Check if deeplink is opening the app

@okwasniewski okwasniewski marked this pull request as ready for review April 10, 2024 08:45
@okwasniewski okwasniewski linked an issue Apr 10, 2024 that may be closed by this pull request
@okwasniewski okwasniewski merged commit 9a00554 into main Apr 10, 2024
15 checks passed
okwasniewski added a commit that referenced this pull request Apr 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 12, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Apr 30, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request May 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request May 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jun 10, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
@okwasniewski okwasniewski deleted the pr/139 branch June 10, 2024 09:52
okwasniewski added a commit that referenced this pull request Jun 21, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jun 21, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jun 24, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jul 15, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jul 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jul 29, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Jul 31, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Aug 5, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Aug 23, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Aug 23, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Aug 26, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Aug 26, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
okwasniewski added a commit that referenced this pull request Sep 12, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 16, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 16, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 17, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 17, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 24, 2024
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep linking is not working
2 participants