This repository has been archived by the owner on May 16, 2023. It is now read-only.
Fix codegen for aws-lambda-go <= v1.15.0 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is now generated for https://github.com/aws/aws-lambda-go/tree/v1.16.0.
|
Although there are sample CodeBuild events no tests were synthesized because of #7. I may tackle that one for completeness. |
LegNeato
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.
For
aws-lambda-gov1.16.0 with aws/aws-lambda-go#274 a structureAPIGatewayV2HTTPRequestContextwas added with nested struct definitions which Rust does not support and this code generator cannot handle.I can open an issue in https://github.com/aws/aws-lambda-go pointing this out and asking for all structs to be defined at the top level.
Opened aws/aws-lambda-go#276.