Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET SDK Update & Integration test fix #2505

Merged
merged 1 commit into from
Mar 19, 2019
Merged

.NET SDK Update & Integration test fix #2505

merged 1 commit into from
Mar 19, 2019

Conversation

devlead
Copy link
Member

@devlead devlead commented Mar 19, 2019

@devlead devlead requested a review from gep13 March 19, 2019 16:10
bjorkstromm
bjorkstromm approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

gep13
gep13 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Mar 19, 2019

@devlead are the failing builds "expected"

@devlead devlead force-pushed the feature/fixintegrationtestsupdatesdk branch from be1ae42 to fbd3322 Compare March 19, 2019 17:22
@devlead
Copy link
Member Author

devlead commented Mar 19, 2019

@devlead are the failing builds "expected"

@gep13 No was an error in Pipelines build definition, corrected and triggered a new build, which hopefully succeeds.

@gep13 gep13 merged commit e140acb into cake-build:develop Mar 19, 2019
@gep13
Copy link
Member

gep13 commented Mar 19, 2019

@devlead your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

@bjorkstromm bjorkstromm bjorkstromm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devlead @gep13 @bjorkstromm