Clean up some parser tests #2019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seem to be cases with input containing spaces. As it is not the case any more, and split with that parameter set doesn't really help in udnerstanding the test essense, it is now replaces with array initialization expression
As it seems there used to be a dependency on file system and specific file existance when figuring out what default script file to use. Another thing, there seem to have been two potential default scripts, 'build.cake' and '.cakefile' (and this is where file existance check might have had sense). Anyways, doesn't seem like '.cakefile' default is around any more Tests are just cleaned to reflect the current state of the matters
|
@homelchenko thank you for taking the time to submit this PR. I was just wondering if you had a chance to read through our contributing guidelines. Was there an issue created to go along with this PR? Thanks |
|
@gep13 I did. I even asked on gitter what approach should be taken for PRs like this one (like not really adding new features but rather of housekeeping nature), and got advice to submit a PR to provide the context along with code for the discussion as it proved to be extremely hard to explain what I meant without pinpointing exact line numbers. So, to answer your next question: no, there's no an open issue. |
|
Sorry for the delay. Your changes merged in c81be32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly, raising this as a PR to provide a context for the conversation about some ArgumentParser tests
As it seems there used to be a dependency on file system and specific file existence when figuring out what default script file to use.
Another thing, there seem to have been two potential default scripts, 'build.cake' and '.cakefile' (and this is where file existence check might have had sense). Anyways, doesn't seem like '.cakefile' default is around any more
Tests are just cleaned to reflect the current state of the matters