GH1537: Refactor XmlPeek alias to use XPathNavigator #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #1537 |
gep13
changed the title
kcamp
force-pushed
the
GH1537
branch
2 times, most recently
from
98f645d
to
b6b2751
Compare
… handle retrieval of element values; add supporting tests
|
@kcamp your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the revised
XmlPeekalias to address the issues described in GH1537.The PR is drafted from the code sample provided in the original issue nearly 1:1 with a couple of small optimizations; from reflecting the
XmlDocumentandXPathNavigatorsource, it appears that the extranullchecks are extraneous. I can revise accordingly if that's understood to be incorrect or otherwise desirable.Overall, I added the test coverage given the existing sample content and also included the sample document as provided for posterity/regression.