Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call multiple tasks from CLI in Frosting #4122

Closed
2 tasks done
juwens opened this issue Feb 23, 2023 · 5 comments · Fixed by #4123
Closed
2 tasks done

Call multiple tasks from CLI in Frosting #4122

juwens opened this issue Feb 23, 2023 · 5 comments · Fixed by #4123
Assignees
Labels
Milestone

Comments

@juwens
Copy link

juwens commented Feb 23, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

Cake runner

Cake Frosting

Cake version

3.0.0

Operating system

Linux, Windows, macOS

Operating system architecture

64-Bit

CI Server

No response

What are you seeing?

Feature introduced with issue #2470 and PR #4054 was not implemented for frosting.

when i do build.ps1 --target=A --target=B only B gets executed.

What is expected?

A and B are executed

Steps to Reproduce

build.ps1 --target=A --target=B

Output log

No response

@juwens
Copy link
Author

juwens commented Feb 23, 2023

@devlead @FrankRay78

@FrankRay78
Copy link
Contributor

Thank you for this PR @juwens , my bad in that I didn't also include it in Frosting. My PR was done early on in my FOSS career and I didn't know the cake codebase well enough. The omission also wasn't picked up on review.

@juwens
Copy link
Author

juwens commented Feb 24, 2023

hey @FrankRay78, no need to excuse. That you contributed a cool feature (several people were looking for) to a FOSS project is awesome. 🙂
I, for example, do it way too rarely.
Oversight happen to everyone, no matter if junior or senior developer. Especially in complicated scenarios like cake, where two cli "frontends" exist for one core logic.
I'm not sure either if my PR is technically correct. It's more of a: basis for discussion.
I guess i'm in your position now ^^

@augustoproiete augustoproiete added this to the Next Major Candidate milestone Apr 2, 2023
@augustoproiete augustoproiete changed the title "Call multiple tasks from CLI" was not implemented for Frosting Call multiple tasks from CLI in Frosting Apr 2, 2023
augustoproiete added a commit that referenced this issue Apr 2, 2023
GH-4122: Make multiple arguments available in Frosting
@augustoproiete augustoproiete linked a pull request Apr 2, 2023 that will close this issue
@augustoproiete
Copy link
Member

Resolved by #4123

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v3.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants