Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptAnalyzer.Analyze() should not throw, instead return list of errors #1746

Closed
bjorkstromm opened this issue Aug 12, 2017 · 0 comments
Closed

ScriptAnalyzer.Analyze() should not throw, instead return list of errors #1746

bjorkstromm opened this issue Aug 12, 2017 · 0 comments
Assignees
@bjorkstromm
Labels
Improvement
Milestone
v0.22.0

Comments

@bjorkstromm
Copy link
Member

Will make life easier with Cake.Bakery
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Aug 13, 2017
@bjorkstromm
(cake-buildGH-1746) ScriptAnalyzer will not throw on error.
7bee399 
- ScriptAnalyzer will not throw on error. Instead the result will
indicate if analysis succeeded or not. A list of errors is also present
in the analyzer result.
- Fixes cake-build#1746
@bjorkstromm bjorkstromm mentioned this issue Aug 13, 2017
Merged
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Aug 14, 2017
@bjorkstromm
(cake-buildGH-1746) ScriptAnalyzer will not throw on error.
e31897c 
- ScriptAnalyzer will not throw on error. Instead the result will
indicate if analysis succeeded or not. A list of errors is also present
in the analyzer result.
- Fixes cake-build#1746
@gep13 gep13 added this to the v0.22.0 milestone Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorkstromm bjorkstromm

Labels
Improvement
Projects
None yet
Milestone
v0.22.0
Development

No branches or pull requests
2 participants
@gep13 @bjorkstromm