Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node16 #41

Closed
nils-a opened this issue Oct 11, 2022 · 11 comments
Closed

Update to Node16 #41

nils-a opened this issue Oct 11, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nils-a
Copy link
Member

nils-a commented Oct 11, 2022

Running the action currently produces a warning:

Node.js 12 actions are deprecated. For more information 
see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. 
Please update the following actions to use Node.js 16: cake-build/cake-action
@ecampidoglio
Copy link
Member

On it.

@ecampidoglio ecampidoglio self-assigned this Oct 15, 2022
@ecampidoglio ecampidoglio added the enhancement New feature or request label Oct 15, 2022
@mabead
Copy link

mabead commented Nov 14, 2022

@ecampidoglio Do you have an ETA for the upgrade to node 16? I am now cleaning all our workflow files and it would be handy to have the fix for cake. Thanks.

@ecampidoglio
Copy link
Member

@mabead I plan on releasing a new version this week.

@ecampidoglio
Copy link
Member

Resolved in 94fa55b.

@mabead
Copy link

mabead commented Dec 1, 2022

Thanks for the update @ecampidoglio! Could you please post an update here once you've published a new version cake-action on the github marketplace? Thanks...

@TheNr1Guest
Copy link

I'm still getting the warning message using the latest cake-action:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: cake-build/cake-action@v1.4.1

@ecampidoglio
Copy link
Member

Moving to Node.js 16 is a breaking change. As such, it's going to be part of v2, along with a few other improvements that break backwards-compatibility (#17).

Since the upgrade has already been merged into master, you can change your workflows to reference that version of the cake-action:

steps:
  - name: Run the Cake script
    uses: cake-build/cake-action@master

If you prefer a more predictable build, you can instead reference the specific commit that contains the upgrade to Node.js 16:

steps:
  - name: Run the Cake script
    uses: cake-build/cake-action@94fa55b4f83cee90f2621654eba6a056ae71df90

Of course, this is a temporary measure. Once v2 is out, you can just change that to cake-build/cake-action@v2.

@TheNr1Guest
Copy link

When will v2 be released?

@baynezy
Copy link
Contributor

baynezy commented Jan 30, 2024

Any update on a V2 release? Do you need any assistance?

@ecampidoglio
Copy link
Member

Resolved by 94fa55b.

@ecampidoglio
Copy link
Member

Version 2.0.0 is out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants