You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the particle/solid phase dimension has a singleton dimension for nparshells even though nparshells can never be larger than 1.
This is not consistent with other units.
E.g. a GRM has no singleton dimension for nrad.
Also, this is a breaking change in the interface that came when updating the solution recorder from push to pull.
@sleweke already had some idea how to fix this, right? 🤓
The text was updated successfully, but these errors were encountered:
Restores the previous behavior when reporting the solution of the LRMP
and CSTR units: The singleton particle shell dimension is removed from
the output tensor.
Fixescadet#133.
Restores the previous behavior when reporting the solution of the LRMP
and CSTR units: The singleton particle shell dimension is removed from
the output tensor.
Fixes#133.
Currently, the particle/solid phase dimension has a singleton dimension for nparshells even though nparshells can never be larger than 1.
This is not consistent with other units.
E.g. a GRM has no singleton dimension for nrad.
Also, this is a breaking change in the interface that came when updating the solution recorder from push to pull.
@sleweke already had some idea how to fix this, right? 🤓
The text was updated successfully, but these errors were encountered: