Update quic-go to v0.37.0, bump to Go 1.20 minimum

[marten-seemann]

See https://github.com/quic-go/quic-go/releases/tag/v0.37.0 for release notes.

[marten-seemann]

As far as I can tell, CI is failing because it's still using Go 1.19 for a number of jobs. quic-go v0.37.0 only support Go 1.20 and 1.21.

[mholt]

We typically ensure support for the previous major Go release for packaging purposes. But I'm 100% OK with upgrading to Go 1.20 now (Go 1.21 is in RC phase) especially given the benefits of this upgrade. Thanks for your great work on this!! Exciting times.

Thanks for the PR! :)

PS. I am subscribed to new releases on your repo too, you always just beat me to it 😄

[mholt]

Made Go 1.20 required instead of Go 1.19, but the CI tests are still the same after re-running. I'll try closing and re-opening the PR...

[francislavoie]

I pushed a commit to bump the minimum to Go 1.20.

[mholt]

Hang on, now the linter's drunk. Re-running

[francislavoie]

Linter wasn't working because we were on an older golangci-lint version which didn't support 1.20.

[francislavoie]

Welp. It's still not working and I don't know why 😭

I have to go afk to do something else but I'll try again later.

[mholt]

I wonder if we could get away with not changing the CI at all? Even if the 1.19 tests fail we could still merge this now that 1.19 is no longer required to succeed.

[marten-seemann]

None of my business, but why keep 1.19 now that’s it’s guaranteed to fail?

[francislavoie]

We're not 🤔 where are you seeing that

[francislavoie]

Okay, this should be good to go now 👍

I had to remove weakrand.Seed(time.Now().UnixNano()) because since https://golang.org/doc/go1.20#math/rand, it's already globally seeded by default. Nice and simple!

[marten-seemann]

I was just replying to @mholt’s comment:

I wonder if we could get away with not changing the CI at all? Even if the 1.19 tests fail we could still merge this now that 1.19 is no longer required to succeed.

[mholt]

Awesome, thanks for the CI fixes Francis!

Re: my comment -- I was just suggesting a quick-and-dirty way to get this mergeable. But I appreciate the effort to fix the problem with CI instead 😊

We got approval from the RHEL maintainer Carl to go ahead and bump up to Go 1.20 a little early.

Thank you everyone!