Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listeners: embed net.UDPConn to allow automatic optimization by quic-go #5606

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

WeidiDeng
Copy link
Member

…tic optimization by quic-go

Fix 5605, 3932.

As a side effect, less code for interface implementation.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Jun 30, 2023
@francislavoie francislavoie changed the title embed net.UDPConn instead of net.PacketConn interface to allow automa… listeners: embed net.UDPConn to allow automatic optimization by quic-go Jun 30, 2023
@francislavoie francislavoie added this to the v2.7.0 milestone Jun 30, 2023
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is even better than I was working on locally!

Thanks 😊

@mholt
Copy link
Member

mholt commented Jun 30, 2023

Interesting, goreleaser-check is failing. https://github.com/caddyserver/caddy/actions/runs/5420166639/jobs/9866067348

@mohammed90 Looks like we are using deprecated properties 🧐

@mohammed90
Copy link
Member

mohammed90 commented Jun 30, 2023

Interesting, goreleaser-check is failing. https://github.com/caddyserver/caddy/actions/runs/5420166639/jobs/9866067348

@mohammed90 Looks like we are using deprecated properties 🧐

On it!

Edit: Here #5608

@mholt
Copy link
Member

mholt commented Jun 30, 2023

Awesome, thanks Mohammed! Retesting.

@mholt mholt merged commit 710824c into master Jun 30, 2023
22 checks passed
@mholt mholt deleted the quic-go-interfaces branch June 30, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quic: need to pass a (maximally thinly wrapped) net.UDPConn to quic-go
4 participants