Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): fix eacces in WSL when creating virtualenvs #272

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix(tests): fix eacces in WSL when creating virtualenvs #272

merged 1 commit into from
Nov 23, 2023

Conversation

manekinekko
Copy link
Collaborator

@manekinekko manekinekko commented Nov 23, 2023 •
edited
Loading

There was a missing OS separator sep in this line that failing with an EACCESS error when running tests on WSL:

jco/tests/virtualenvs/base.js

Line 8 in df1f300

export const testDir = await mkdtemp(tmpdir());

image

@guybedford
Copy link
Collaborator

Nice, thank you. Also need to fix a flake on the main Windows CI, will get to that soon too.

@guybedford guybedford added this pull request to the merge queue Nov 23, 2023
@guybedford guybedford removed this pull request from the merge queue due to a manual request Nov 23, 2023
@guybedford guybedford added this pull request to the merge queue Nov 23, 2023
@guybedford guybedford removed this pull request from the merge queue due to a manual request Nov 23, 2023
@guybedford guybedford merged commit abb3dd0 into main Nov 23, 2023
5 of 6 checks passed
@guybedford guybedford deleted the fix-tests-wsl branch November 23, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford Awaiting requested review from guybedford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manekinekko @guybedford