Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more conformance tests #266

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: more conformance tests #266

merged 1 commit into from
Nov 17, 2023

Conversation

guybedford
Copy link
Collaborator

@guybedford guybedford commented Nov 17, 2023

This adds 8 new passing tests (I've already crossed them off in the corresponding issues).

  • Resolves Jco transpile: implementation of wasi-clocks for Node.js #201.
  • Resolves most of the CLI tests, with just the stdin tests remaining to do which I'll post as a follow-up PR.
  • Adds a custom --jco-import option to jco run to allow for custom environment virtualization which should work as a pattern to be able to ensure the right environment for testing.
  • Adds a new --jco-debug option to jco run which doesn't delete the temporary files (so they can be debugged) and also outputs the trace calls.
  • Resolves a resources bug I hit on one of the cases, where the resource table wasn't being initialized.
  • Updates the utf8 encoder to avoid reallocations, since these are unsupported in the test binaries.

Going to start adding this to my PRs: Progress: 27/98 tests

@guybedford guybedford added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit dfe7173 Nov 17, 2023
6 checks passed
@guybedford guybedford deleted the conformance branch November 17, 2023 02:29
@manekinekko
Copy link
Collaborator

Adds a new --jco-debug option to jco run which doesn't delete the temporary files (so they can be debugged) and also outputs the trace calls.

Thank you!! I love this. This will same be a LOT of time :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jco transpile: implementation of wasi-clocks for Node.js
2 participants