Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly Formatting Changes #3

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

boonepeter
Copy link

  • Brought the code formatting up to pep8 standards (mostly changing 2 to 4 spaces for indentation and some other spacing/parentheses things).
  • Formatted the docstrings like numpy docstrings.
  • Made some imports explicit
  • Changed lines 138 to np.fill_diagonal()

If the change in formatting is too much let me know, as I don't want to step on your toes. Other than range -> np.fill_diagonal() I did not make any changes that should affect how the algorithm runs. I pip installed my changes and everything seemed to be working correctly.

@bwlewis
Copy link
Owner

bwlewis commented Mar 11, 2019

I've got a few more changes coming this week...stay tuned...

@boonepeter
Copy link
Author

Sounds great. I did this one by hand, but when you push changes I can run it through a formatter first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants