Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prcomp_irlba code has a bug in dealing with scaling #25

Closed
Xiaojieqiu opened this issue Oct 22, 2017 · 3 comments
Closed

prcomp_irlba code has a bug in dealing with scaling #25

Xiaojieqiu opened this issue Oct 22, 2017 · 3 comments

Comments

@Xiaojieqiu
Copy link

when you set scale. = TRUE in the prcomp_irlba function, it will throw an error

> prcomp_irlba(exprs(HSMM), scale. = T)
Error in if (tol * ans$d[1] < eps) warning("convergence criterion below machine epsilon") : 
  missing value where TRUE/FALSE needed

I think the error comes from the variable center in line 94 of the prcomp.R file, it should be
args$center instead of center because center is a logic value by default.

@bwlewis
Copy link
Owner

bwlewis commented Oct 24, 2017

Shoot, sorry about this newly introduced bug. Working on this today, will have a fix on GitHub tonight. I'll plan for a bug fix release to CRAN by the end of the week or so.

temporary work-around: supply an explicit scaling vector instead of TRUE/FALSE

@bwlewis
Copy link
Owner

bwlewis commented Oct 24, 2017

Try the GitHub master branch now. I have a few other issues to fix and then will submit to CRAN again.

@bwlewis
Copy link
Owner

bwlewis commented Mar 20, 2018

This should be fixed on CRAN version 2.3.2, please re-open if you still have troubles.

@bwlewis bwlewis closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants