Rename childRef to registerChild and add some docs #947
Conversation
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 57 57
Lines 1632 1632
=======================================
Hits 1475 1475
Misses 157 157
Continue to review full report at Codecov.
|
docs/WindowScroller.md
Outdated
| ReactDOM.render( | ||
| <WindowScroller> | ||
| {({ height, isScrolling, registerChild, scrollTop }) => ( | ||
| <div ref={registerChild}> |
There was a problem hiding this comment.
Is the wrapper div necessary? (Why?)
There was a problem hiding this comment.
It's an example of using registerChild Usually it's more complex layout which requires information from WindowScroller.
There was a problem hiding this comment.
I think the docs should make that clearer then, probably.
The other registerChild props get attached to the List (or Table, whatever) itself. This one could too, right? So if we show otherwise, we should probably add a comment or explanation about why or when you might want to do this.
| @@ -53,3 +53,37 @@ ReactDOM.render( | |||
| document.getElementById('example') | |||
| ); | |||
| ``` | |||
|
|
|||
| or using `registerChild` you can specify grid container deeper in layout (by default `WindowScroller` uses `ReactDOM.findDOMNode` function) | |||
No description provided.