Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row direction support #1071

Merged
merged 3 commits into from
Apr 16, 2018

Conversation

bardiarastin
Copy link
Contributor

this PR is for #1070 😊
all tests passing βœ”
this adds row direction support to masonry (right to left cells)

@wuweiweiwu
Copy link
Contributor

@bardiarastin I'm thinking of instead of having a rowDirection prop, just have it as a opt-in boolean prop/.

For example:

<Masonry
  {...this.props}
  rtl
/>

@bardiarastin
Copy link
Contributor Author

@wuweiweiwu thanks for feedback, I had the same idea but this is from discussion in #1070

@wuweiweiwu
Copy link
Contributor

@bardiarastin I see. Looks good to me πŸ‘

@wuweiweiwu wuweiweiwu merged commit 0418670 into bvaughn:master Apr 16, 2018
@bvaughn
Copy link
Owner

bvaughn commented Apr 16, 2018

Hi πŸ‘‹ Looks like this PR broke CI because it wasn't formatted with Prettier first (yarn prettier) πŸ˜„

I fixed it (1e1746a) and pushed. Just an FYI.

@bardiarastin
Copy link
Contributor Author

thanks @bvaughn, I made another PR to add yarn prettier to contributing docs 😬

@wuweiweiwu
Copy link
Contributor

Woops. my bad. Do you think it is worth setting up CI for PRs? cc @bvaughn

@bardiarastin
Copy link
Contributor Author

there are good free services for open source projects, it would be cool if it does not need spending a lot of time πŸ˜ƒ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants