Update AssetPair.php #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ValueObjects/AssetPair.php Asset2 is not necceccary and its even possible to get more than two informations about assetpairs from the api.
|
Could you please get links to API where I can read about this case. And also it will be awesome to cover changes with unit tests. |
changed GetTradableAssetPairsTest.php to show, that more than one assetPair is working.
|
The Api Documentation is: https://docs.kraken.com/rest/#operation/getTradableAssetPairs |
|
Thanks, despite the long delay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asset2 is not necceccary for the api request.
And its even possible to send more than two assets to the api.