Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 5.6.4 #4484

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jan 27, 2021

Description

Updates the Gradle Wrapper to version 5.6.4

Motivation and Context

Updating Gradle ensures that the latest warnings and depreciation messages are included. It also improves build speed.

Part of #4482.

@google-cla google-cla bot added the cla: yes label Jan 27, 2021
@sjudd sjudd added the import-ready Indicates the PR is ready to be imported to Google. label Jan 29, 2021
Copy link
Collaborator

@kanelbulle kanelbulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

The checksum for the gradle-wrapper.jar does not match any known checksums of gradle releases. I think you might have built the wrapper without using the upgraded gradle version. See https://docs.gradle.org/current/userguide/gradle_wrapper.html#troubleshooting_a_checksum_mismatch for more info on how to correct this.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 30, 2021

Are you sure? The Gradle Wrapper Validation action reports:

Found known Gradle Wrapper JAR files:
3dc39ad650d40f6c029bd8ff605c6d95865d657dbfdeacdb079db0ddfffedf9f gradle/wrapper/gradle-wrapper.jar

@kanelbulle
Copy link
Collaborator

You're right, I didn't see that! I was comparing manually with the published SHAs. Sorry about that & thanks for the change!

@kanelbulle
Copy link
Collaborator

Apologies for the delay! Had to get this approved internally.

@copybara-service copybara-service bot merged commit 4b48ea3 into bumptech:master Feb 12, 2021
@EwoutH
Copy link
Contributor Author

EwoutH commented Feb 12, 2021

No worries, thanks the effort and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes import-ready Indicates the PR is ready to be imported to Google.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants