Evict oldest half of cache on TRIM_MEMORY_RUNNING_CRITICAL #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygnessin
changed the title
sjudd
requested changes
Feb 11, 2018
| @@ -220,7 +220,9 @@ public void trimMemory(int level) { | |||
| if (level >= android.content.ComponentCallbacks2.TRIM_MEMORY_BACKGROUND) { | |||
| clearMemory(); | |||
| } else if (level >= android.content.ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN) { | |||
There was a problem hiding this comment.
Use || instead of duplicating the size logic
| @@ -142,6 +142,8 @@ public synchronized void trimMemory(int level) { | |||
| clearMemory(); | |||
| } else if (level >= android.content.ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN) { | |||
| evictToSize(maxSize / 2); | |||
| } else if (level == android.content.ComponentCallbacks2.TRIM_MEMORY_RUNNING_CRITICAL) { | |||
There was a problem hiding this comment.
Use || instead of duplicating the size logic.
|
@sjudd thanks for the feedback, I addressed your comments |
sjudd
approved these changes
Feb 13, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trim half of resource cache allocations when receiving TRIM_MEMORY_RUNNING_CRITICAL in
trimMemory()See #2810
Also, while in the code I updated some outdated comments, and replaced
maxSizewithgetMaxSize()inLruBitmapPoolMotivation and Context
Glide is excellent at trimming memory when backgrounded, but fails to do anything when
trimMemory()is received while foregrounded. This fixes that, which may save an app from slowing down or encountering an OOM while foregrounded, especially if the foreground context isn't the one using the images.@sjudd had some good points about this strategy in #2810, which is why I've elected to be pretty conservative by only evicting half the cache when TRIM_MEMORY_RUNNING_CRITICAL is encountered. I also think this makes sense because the next stage after CRITICAL is TRIM_MEMORY_COMPLETE, which Glide already handles by evicting the entire cache. Thus, this follows the same pattern as the backgrounded behavior: Half of the cache is evicted first, then one level up the whole cache is evicted.
If anybody thinks the strategy should be more or less aggressive I'd be happy to discuss, but hopefully that explains my rationale. I also think that if the community finds this effective, we could always make it more aggressive in a future update.
Thank you for considering my contribution!