New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix expected failures flag ux #42

Merged

elliotmjackson merged 4 commits into main from ejackson/bugfix-ux

Jul 4, 2023

Contributor

elliotmjackson commented Jul 4, 2023

Other flags use an underscore with multi-word flags, expected-failures uses a hyphen. This change repairs this oversight

elliotmjackson and others added 4 commits

July 4, 2023 13:47


          checkpoint

05ca10c


          Delete .bazelproject

32569ec


          checkpoint

cb7da26


          checkpoint

f3599b9

pgmitche approved these changes

View reviewed changes

pgmitche left a comment

looks uniform to me

elliotmjackson merged commit bf89be4 into main

2 checks passed

elliotmjackson deleted the ejackson/bugfix-ux branch

July 4, 2023 14:37

pkwarren pushed a commit that referenced this pull request


          Break everything (#42)

ada1822

igor-tsiglyar pushed a commit to igor-tsiglyar/protovalidate that referenced this pull request


          Bump github.com/google/cel-go from 0.17.6 to 0.18.0 (bufbuild#42)

0915ec1

Bumps [github.com/google/cel-go](https://github.com/google/cel-go) from
0.17.6 to 0.18.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/cel-go/releases">github.com/google/cel-go's
releases</a>.</em></p>
<blockquote>
<h2>Release v0.18.0</h2>
<h2>Features</h2>
<p>The latest release of CEL introduces validators (<a
href="https://redirect.github.com/google/cel-go/issues/775">#775</a>)
and optimizers (<a
href="https://redirect.github.com/google/cel-go/issues/804">#804</a>, <a
href="https://redirect.github.com/google/cel-go/issues/827">#827</a>)
and migrates the core CEL internals off of the
protobuf expression and type representations (<a
href="https://redirect.github.com/google/cel-go/issues/789">#789</a>).</p>
<ul>
<li>String format validator <a
href="https://redirect.github.com/google/cel-go/issues/775">#775</a></li>
<li>Create a Function that Reverses a String <a
href="https://redirect.github.com/google/cel-go/issues/796">#796</a></li>
<li>Introduce pre-order / post-order visitor pattern <a
href="https://redirect.github.com/google/cel-go/issues/813">#813</a></li>
<li>Add Libraries() function to Env <a
href="https://redirect.github.com/google/cel-go/issues/822">#822</a></li>
<li>Static optimizer for constant folding <a
href="https://redirect.github.com/google/cel-go/issues/804">#804</a></li>
<li>Inlining optimizer <a
href="https://redirect.github.com/google/cel-go/issues/827">#827</a></li>
<li>FindStructTypeFields support for types.Provider <a
href="https://redirect.github.com/google/cel-go/issues/814">#814</a></li>
</ul>
<h2>Breaking Changes</h2>
<p>The following PR changes the API signature of the
<code>checker.AstNode</code> method <code>Expr</code> to return an
<code>ast.Expr</code>.</p>
<ul>
<li>Migrate the checker.Coster to the ast.Expr <a
href="https://redirect.github.com/google/cel-go/issues/798">#798</a></li>
</ul>
<h2>Fixes</h2>
<ul>
<li>Nil safety checks for cel.Ast <a
href="https://redirect.github.com/google/cel-go/issues/784">#784</a></li>
<li>Fix cost estimates to propagate result sizes <a
href="https://redirect.github.com/google/cel-go/issues/787">#787</a></li>
<li>Catch invalid literals created from expression factories <a
href="https://redirect.github.com/google/cel-go/issues/810">#810</a></li>
<li>Ensure stable ordering of overload candidates <a
href="https://redirect.github.com/google/cel-go/issues/817">#817</a></li>
<li>Clarify replace with/by empty string <a
href="https://redirect.github.com/google/cel-go/issues/820">#820</a></li>
<li>Fix functional exemptions for homogeneous literal checks <a
href="https://redirect.github.com/google/cel-go/issues/832">#832</a></li>
<li>Fix logical operator folding that only involve literals <a
href="https://redirect.github.com/google/cel-go/issues/833">#833</a></li>
<li>Upgrade go-genproto to latest <a
href="https://redirect.github.com/google/cel-go/issues/831">#831</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bboogler"><code>@bboogler</code></a>
made their first contribution in <a
href="https://redirect.github.com/google/cel-go/pull/796">google/cel-go#796</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/cel-go/compare/v0.17.1...v0.18.0">https://github.com/google/cel-go/compare/v0.17.1...v0.18.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/google/cel-go/commit/5db3640443d76752fb201c575f0ce06e4c202459"><code>5db3640</code></a>
Inlining optimizer (<a
href="https://redirect.github.com/google/cel-go/issues/827">#827</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/8943046ee066d9fefea77ce856f175a987271925"><code>8943046</code></a>
Upgrade go-genproto to latest (<a
href="https://redirect.github.com/google/cel-go/issues/831">#831</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/4eebcf38782990c8636f14111f75c6b241c505b0"><code>4eebcf3</code></a>
Fix logical operator folding that only involve literals (<a
href="https://redirect.github.com/google/cel-go/issues/833">#833</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/bfccebd9086672bb5cbd18e7ef9c9973cca6eb50"><code>bfccebd</code></a>
Fix functional exemptions for homogeneous literal checks (<a
href="https://redirect.github.com/google/cel-go/issues/832">#832</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/705546a3fd4975d917e972b33596796ef2e739c0"><code>705546a</code></a>
Static optimizer for constant folding (<a
href="https://redirect.github.com/google/cel-go/issues/804">#804</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/509c1d6161f0ae6bbb91cab1e65daeefb0109316"><code>509c1d6</code></a>
Document that string reverse was introduced in version 3 of ext.strings
(<a
href="https://redirect.github.com/google/cel-go/issues/824">#824</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/dd6d31dd8b4d3f220f07d0dd906476f9687a7d79"><code>dd6d31d</code></a>
Fix slice handling in Env.Libraries() (<a
href="https://redirect.github.com/google/cel-go/issues/825">#825</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/8a4595524249653b05082a3ce5b1acb75c448844"><code>8a45955</code></a>
Add Libraries() function to Env (<a
href="https://redirect.github.com/google/cel-go/issues/822">#822</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/78039f1fa0bb190af877ed6fd7aefe7a4074cd18"><code>78039f1</code></a>
Clarify replace with/by empty string (<a
href="https://redirect.github.com/google/cel-go/issues/820">#820</a>)</li>
<li><a
href="https://github.com/google/cel-go/commit/2de99521d8c8d4f5c1aa08ac4b4dbc414578396c"><code>2de9952</code></a>
Ensure stable ordering of overload candidates during dynamic dispatch
(<a
href="https://redirect.github.com/google/cel-go/issues/817">#817</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/google/cel-go/compare/v0.17.6...v0.18.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/google/cel-go&package-manager=go_modules&previous-version=0.17.6&new-version=0.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet