Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGV can't be installed from GitHub Releases? #764

Closed
suzuki-shunsuke opened this issue Dec 28, 2022 · 1 comment · Fixed by #765
Closed

PGV can't be installed from GitHub Releases? #764

suzuki-shunsuke opened this issue Dec 28, 2022 · 1 comment · Fixed by #765

Comments

@suzuki-shunsuke
Copy link
Contributor

suzuki-shunsuke commented Dec 28, 2022 •
edited
Loading

Hi, I have a question.

There are assets in GitHub Releases, so I think we can install PGV from GitHub Releases.

https://github.com/bufbuild/protoc-gen-validate/releases

But according to the document, PGV can only be installed from source.

protoc-gen-validate/README.md

Lines 83 to 88 in 0bd3773

Installing PGV can currently only be done from source:
```sh
# fetches this repo into $GOPATH
go get -d github.com/envoyproxy/protoc-gen-validate
```

Installing PGV can currently only be done from source:

Is this document correct?
@suzuki-shunsuke suzuki-shunsuke mentioned this issue Dec 28, 2022
Merged
@suzuki-shunsuke
Copy link
Contributor Author

I've created a pull request.

@suzuki-shunsuke suzuki-shunsuke mentioned this issue Dec 28, 2022
Merged
elliotmjackson pushed a commit that referenced this issue Dec 28, 2022
@suzuki-shunsuke
docs: fix installation (#765) #patch
0ff1785 
Close #764

You can download prebuilt binaries from GitHub Releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix installation
1 participant
@suzuki-shunsuke