Add yaml format #2470
Merged
Add yaml format #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
reviewed
Oct 4, 2023
There was a problem hiding this comment.
- The only tests I see are around
buf convert, can we do some round trip tests aroundbuf build? I believe we already have some. - What happens if I use snake case keys instead of camel case keys in my YAML file?
protojsonhandles both, wondering if we have an answer for this. Optimally, we'd have a test for this as well (assuming we handle both).
Added a test that uses the yaml format as both output and input to/from buf build. Is this what you mean, or do you want more tests, somewhere else?
protoyaml handles both, and tests that in it's repo. |
… file formats (#2601) This also deletes the `bufconvert` and `bufref` packages entirely in the process, and renames `ImageRef` to `MessageRef` in `buffetch`. This eliminates the separate code paths for conversion, and everything else.
bufdev
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example error output: