mempool: Remove returned error from ProcessOrphans

[dajohi]

ProcessTransaction could have accepted a new transaction into mempool
but could have returned a reject message if a no-longer-orphan
transaction failed to be accepted. This would also skip any
additional no-longer-orphans, keeping them in the orphan pool.

Instead of returning an error incorrectly, log the error and skip
the no-longer-orphan transaction. This allows the rest of the
no-longer-orphans to be processed as well.

[davecgh]

Commit message typos:

if an -> if a
would also skip the any -> would also skip any

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

^{mempool.go, line 1090 [r1] (raw file):}
This defer is no longer needed since there is no longer a return. No sense in having the extra overhead.

mp.Lock()
mp.processOrphans(hash)
mp.Unlock()

---

Comments from the review on Reviewable.io

[dajohi]

updated.

[davecgh]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[davecgh]

OK

[davecgh]

@jrick and I were talking about this and the TODO in the case where the length of missing parents is non-zero, it should be put back into the orphan pool and continue thereby skipping the relay.

[davecgh]

Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[davecgh]

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[davecgh]

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[jrick]

ok

[davecgh]

OK