Move non-mempool specific functions to new file.

[dajohi]

No functional change. Add tests.

[davecgh]

As discussed on IRC, I like the concept.

[davecgh]

Please give the tests a name string field and include it in the error output. I know there are several tests that don't do that currently, but we've been trying to move that direction since it's much harder to figure out which test failed when only given a number. Granted it's not too difficult when there are only a few tests, but I'd like to be consistent.

[davecgh]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

^{policy.go, line 27 [r1] (raw file):}
Please don't wrap function definitions.

---

Comments from the review on Reviewable.io

[davecgh]

Reviewed 1 of 2 files at r2.
Review status: 2 of 3 files reviewed at latest revision, 9 unresolved discussions, all commit checks successful.

---

^{policy_test.go, line 72 [r2] (raw file):}
This looks leftover. Please use t.Fatalf.

---

^{policy_test.go, line 79 [r2] (raw file):}
Why not just make this *txscript.ScriptBuilder and avoid the extra indirects below?

---

^{policy_test.go, line 158 [r2] (raw file):}
Better error message please. This won't be very useful if it gets hit due to an invalid test case.

---

^{policy_test.go, line 198 [r2] (raw file):}
Please put the actual relay fee that is being tested, not the default. If you want to prove the default hasn't changed, then add another test like func TestDefaultMinRelayFeePolicy(t *testing.T) {...}.

---

^{policy_test.go, line 204 [r2] (raw file):}
Same.

---

^{policy_test.go, line 210 [r2] (raw file):}
Same.

---

^{policy_test.go, line 217 [r2] (raw file):}
Same.

---

^{policy_test.go, line 224 [r2] (raw file):}
Same.

---

^{policy_test.go, line 232 [r2] (raw file):}
Same.

Also, please use a few different values. Only testing 0 and 0.00001 doesn't really exercise the function very well.

---

Comments from the review on Reviewable.io

[davecgh]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[davecgh]

OK