Fix #340 and DropAfterBlockBySha/NewestSha bug. #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,182 @@ | |||
| // Copyright (c) 2013-2014 Conformal Systems LLC. | |||
There was a problem hiding this comment.
Whoops. Will fix that.
aakselrod
force-pushed
the
reorg-fixes
branch
2 times, most recently
from
d6e5d56
to
055bfc2
Compare
|
@aakselrod Thanks for hunting this down and getting it fixed. Looks good. OK |
| if rintbuf != uint32(network) { | ||
| break | ||
| } | ||
| err = binary.Read(dr, binary.LittleEndian, &rintbuf) |
|
Fix looks correct but I added some suggestions for the test code. |
|
Updated test code to comply with @jrick's suggestions. |
| spentTxList = spentTxList[:len(spentTxList)-1] | ||
| // XXX format sTxList and set update Table | ||
| // This code should never be hit - aakselrod | ||
| return fmt.Errorf( |
There was a problem hiding this comment.
Argument syntax formatting here doesn't match the rest of the code base.
- Delete spent TX in setclearSpentData when unspent by block disconnect on reorg; return an error when there's more than one record to delete in the spent TX as that should never happen. - Test spent TX deletion when reorg causes block disconnect. - Test for correct NewestSha results after DropAfterBlockBySha. - Fix DropAfterBlockBySha to update info for NewestSha. - Updated copyright statements in modified files
|
All set. Round 2 OK. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disconnect on reorg.