Allow clients to cancel transaction notifications #342
Conversation
Roasbeef
force-pushed
the
stopnotify
branch
3 times, most recently
from
b9b72f4
to
22aea26
Compare
|
Thanks. I'll review this within the next few days. |
| } | ||
|
|
||
| // StopNotifyReceivedCmd defines the stopnotifyreceived JSON-RPC command. | ||
| type StopNotifyReceivedCmd struct { |
There was a problem hiding this comment.
Minor nitpick, but all of the other command definitions alphabetized, so I think this should be defined before type StopNotifySpentCmd struct to be consistent.
|
I need to test this out still, but aside from my minor nitpick, this reads well. |
|
I noticed this includes |
Roasbeef
force-pushed
the
stopnotify
branch
2 times, most recently
from
ef0b70b
to
dcdc991
Compare
|
I've tested this and everything looks good. The code reads well too. Just need to squash and rebase it and it's good to go. OK |
|
Oh, I just realized I was a bit hasty. While the code is correct and works properly, I noticed the documentation for the JSON-RPC API wasn't updatd. The new commands need to be added to the websocket extensions section of docs/json_rpc_api.md. |
|
This is just waiting on the documentation updates. |
|
The documentation has been updated with the latest commit. |
|
Thanks for the udpates. OK after rebase and squash. |
|
Rebased and squashed 👍 |
|
Thanks, but it's not against the latest master! |
This commit adds 4 new websockets JSON-RPC methods for canceling notifications: * stopnotifyspent * stopnotifyreceived * stopnotifyblocks * stopnotifynewtransactions
This PR aims to address #122 by providing JSON-RPC methods allowing clients to cancel received and spent notifications.
Note: before this can be properly integrated into
btcwallet,btcrpcclientwill need to be updated to usebtcjsonv2.