Add id and timeoffset to getpeerinfo. #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -137,6 +137,7 @@ type GetNetworkInfoResult struct { | |||
|
|
|||
| // GetPeerInfoResult models the data returned from the getpeerinfo command. | |||
| type GetPeerInfoResult struct { | |||
| Id string `json:"addr"` | |||
There was a problem hiding this comment.
This won't be used, so it probably doesn't matter, but json:"id".
|
This is missing help for the new fields as indicated by the build failure. Also, I think |
| Version uint32 `json:"version"` | ||
| SubVer string `json:"subver"` | ||
| Inbound bool `json:"inbound"` | ||
| StartingHeight int32 `json:"startingheight"` | ||
| CurrentHeight int32 `json:"currentheight,omitempty"` |
There was a problem hiding this comment.
I don't think we should be losing this field.
|
Looks good after you bring the |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.