blockchain: fix a bug where a duplicate entry is possible in the mapslice #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate entries are currently possible in the following scenario: 1: Add entries to the mapslice. 2: 1st map is full. Move onto the 2nd map. 3: Delete any entry in the first map. 4: Attempt to add an entry in the 2nd map. When attempting (4), the entry should just be overwritten but a duplicate gets added.
When attempting to insert an entry to the mapslice, we check all the underlying maps to ensure that the entry doesn't exist.
Pull Request Test Coverage Report for Build 8184106558Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test and fixes the bug to fix a case where a duplicate entry in the mapslice is possible.
Not sure if this is related to the other cases we've been seeing since the outpoints should never have duplicates, fixing this is good since the code is assuming that the mapslice will not have duplicates.