Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schnorr: bip-340 compliant signing #2022

Merged
merged 1 commit into from
Aug 15, 2023
Merged

schnorr: bip-340 compliant signing #2022

merged 1 commit into from
Aug 15, 2023

Conversation

wydengyre
Copy link
Contributor

fixes #2021

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5867908269

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 55.339%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 13 73.2%
Totals Coverage Status
Change from base Build 5859661990: -0.02%
Covered Lines: 26794
Relevant Lines: 48418
💛 - Coveralls

Roasbeef
Roasbeef approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎥

@Roasbeef Roasbeef merged commit 40d7a0a into btcsuite:master Aug 15, 2023
3 checks passed
@wydengyre wydengyre deleted the bip-340-signing branch August 16, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schnorr signing deviates from BIP 340
3 participants
@wydengyre @coveralls @Roasbeef