Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schnorr: correct rfc reference in docs #2016

Merged
merged 1 commit into from
Aug 9, 2023
Merged

schnorr: correct rfc reference in docs #2016

merged 1 commit into from
Aug 9, 2023

Conversation

wydengyre
Copy link
Contributor

The RFC used for deterministic nonce generation is rfc6979, not rfc6679. This commit fixes documentation in two places accordingly.

@wydengyre
schnorr: correct rfc reference in docs
880d9f9 
The RFC used for deterministic nonce generation is rfc6979, not rfc6679. This commit fixes documentation in two places accordingly.
guggero
guggero approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5754035679

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 55.282%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
txscript/taproot.go 5 95.31%
peer/peer.go 6 73.49%
Totals Coverage Status
Change from base Build 5747300520: -0.03%
Covered Lines: 26727
Relevant Lines: 48347
💛 - Coveralls

Roasbeef
Roasbeef approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎎

@Roasbeef Roasbeef merged commit d776d9c into btcsuite:master Aug 9, 2023
3 checks passed
@wydengyre wydengyre deleted the fix-docs-rfc6979 branch August 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wydengyre @coveralls @Roasbeef @guggero