btcutil/psbt: export helper functions, fix/add encoding of unknown fields #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4025400808
💛 - Coveralls |
Roasbeef
reviewed
Jan 26, 2023
To unify the way the unknown fields are handled, we change the global ones to a slice of pointers as well. This makes it easier to add generic handler code for unknown fields, if they are uniform across the levels (global, input, output).
|
cc @sputn1ck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of small issues that allow the
btcutil/psbtpackage to be used for adding custom fields (=[]*Unknown) to the transaction itself (global) as well as the outputs. We also export the BIP32 derivation info serialization/de-serialization related functions for easy re-use in other projects.cc @ffranr.