integration: optimize harness for better itest control, restore bitcoind compatibility #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow using a custom btcd executable, we allow specifying a path to a file. If the path is empty, the harness will fall back to compiling one from scratch.
|
I just tested this with our |
jakesylvestre
approved these changes
Nov 11, 2020
guggero
changed the title
Added a commit to fix this. |
The PR btcsuite#1594 introduced a change that made the order of parameters relevant, if one of them is nil. This makes it harder to be backward compatible with the same JSON message if an existing parameter in bitcoind was re-purposed to have a different meaning.
Roasbeef
approved these changes
Nov 14, 2020
| // AllowHighFeesOrMaxFeeRate defines a type that can either be the legacy | ||
| // allowhighfees boolean field or the new maxfeerate int field. | ||
| type AllowHighFeesOrMaxFeeRate struct { | ||
| Value interface{} |
There was a problem hiding this comment.
Ahh, clever way to handle this!
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the integration harness:
btcdbinary to be specified instead of always building it from sourceEverything falls back to the previous behavior if not otherwise specified. Existing users will just need to specify one more parameter.
EDIT: The PR now also contains a commit that restores compatibility with
bitcoind > 0.19! There was a side effect of #1594 that caused thesendrawtransactioncommand not to work anymore.@Roasbeef @wpaulino