Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcjson: add new JSON-RPC errors and document them #1648

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Oct 8, 2020

Just some basic housekeeping - add new JSON-RPC errors and document all the exported error codes. See source.

@onyb onyb added the rpc label Oct 8, 2020
@coveralls
Copy link

coveralls commented Oct 9, 2020

Pull Request Test Coverage Report for Build 297532456

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 53.504%

Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.18%
Totals Coverage Status
Change from base Build 289529546: 0.002%
Covered Lines: 20780
Relevant Lines: 38838

💛 - Coveralls

@onyb onyb added this to the 0.22.0 milestone Oct 12, 2020
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 5e56ca0 into btcsuite:master Oct 26, 2020
@onyb onyb deleted the jsonrpcerr branch October 26, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants