Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: add txid to getblocktemplate response #1639

Merged
merged 1 commit into from
Oct 5, 2020
Merged

rpcserver: add txid to getblocktemplate response #1639

merged 1 commit into from
Oct 5, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Sep 21, 2020

Follow up of #1629.

This PR populates both the txid and hash fields in the RPC server implementation.

@coveralls
Copy link

coveralls commented Sep 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 265827118

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 53.602%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 4 0.0%
Totals Coverage Status
Change from base Build 265195639: 0.03%
Covered Lines: 20729
Relevant Lines: 38672
💛 - Coveralls

@onyb onyb added the rpc label Sep 22, 2020
@onyb onyb added this to the 0.22.0 milestone Sep 22, 2020
jcvernaleo
jcvernaleo approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 0bf42f4 into btcsuite:master Oct 5, 2020
@onyb onyb deleted the getblocktemplate-server-update branch October 5, 2020 14:59
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@onyb @coveralls @jcvernaleo