Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary GOMAXPROCS function calls #1627

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Remove unnecessary GOMAXPROCS function calls #1627

merged 1 commit into from
Sep 14, 2020

Conversation

ipriver
Copy link
Contributor

@ipriver ipriver commented Sep 7, 2020

According to go 1.5 release notes:

By default, Go programs run with GOMAXPROCS set to the number of cores available; in prior releases it defaulted to 1.

There's no need anymore to call it with runtime.NumCPU() argument, it is now used as a default. Removed legacy GOMAXPROCS calls from the project.

onyb
onyb approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jcvernaleo
jcvernaleo approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that use of runtime was crazy old!

OK

@jcvernaleo jcvernaleo merged commit 42782bb into btcsuite:master Sep 14, 2020
@ipriver ipriver deleted the remove_gomaxprocs branch September 14, 2020 14:51
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@onyb onyb onyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipriver @jcvernaleo @onyb