btcd: fix conversion of int to string failing in Go 1.15 #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyb
reviewed
Aug 31, 2020
| @@ -201,7 +201,7 @@ func TestAssignFieldErrors(t *testing.T) { | |||
| }{ | |||
| { | |||
| name: "general incompatible int -> string", | |||
| dest: string(0), | |||
| dest: "\x00", | |||
There was a problem hiding this comment.
Any reason to not use string(rune(0)) here? By the way, "\x00" is fine too..
There was a problem hiding this comment.
No reason, it just felt more natural to write "\x00" for me.
This was referenced Aug 31, 2020
jakesylvestre
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Awesome! I ran this in xplorfin#12 and it appears to fix all the go 1.15 issues for this repo. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
btcdfails to build in Go 1.15 with the following message: