rpcclient: serialize nil inputs to empty list

[torkelrogstad]

Prior to this, calling CreateRawTransaction(nil, ...) failed. We fix this, and add a test for the serialization.

[Rjected]

Nice!

[onyb]

@torkelrogstad I think this deserves an update to the docs of:

• CreateRawTransaction
• CreateRawTransactionAsync
• btcjson.NewCreateRawTransactionCmd

Something like this:

// If the value of inputs is nil, it will be interpreted as an empty slice.

What do you think?

[torkelrogstad]

Pushed some doc tweaks 👍

[onyb]

@torkelrogstad CI is not happy. 🔴

[torkelrogstad]

Seems like I was a bit trigger happy with pushing! Missed a gofmt

[onyb]

Looks good. 👍

[jakesylvestre]

We might have to update this branch from master to get rid of the travis health check

[onyb]

We might have to update this branch from master to get rid of the travis health check

@jakesyl At least on my PRs, rebasing on latest master doesn't get rid of the check. I think it applies to all PRs created before TravisCI was removed. Or perhaps, there are some settings on GitHub/TravisCI that need to be updated.

[jakesylvestre]

I think @Roasbeef might have to remove the check

[torkelrogstad]

We might have to update this branch from master to get rid of the travis health check

I rebased this right before the weekend, without it removing the Travis check.

[Rjected]

In #1575 the .travis.yml file was removed from the repo without the status check being removed as well. Unless we remove the status check, nothing, including updating the branch, will get travis to run.

[Rjected]

Should be good now!

[jcvernaleo]

OK