rpcclient: Add net params to Client #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a chaincfg.Params to the Client rpcclient: parse config to assign params
Rjected
changed the title
Rjected
changed the title
* Change address future struct to contain a network field, so futures can return the correct type for Receive
|
What's the status of this change being marged into master? |
Closed
|
We still need it at @lbryio , we have to fork it... |
|
@Roasbeef this PR is fairly well reviewed, and looks like it is needed by quite a large number of people in the community. Would it be possible to get this merged? |
|
@jcvernaleo I think this is an important PR, can you take a look? |
|
Agree - definitely a high priority issue |
|
@jcvernaleo (as per #1530)
|
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a chaincfg.Params to rpcclient.Client to allow for net-specific RPC commands to be called.
Removes a multiple
type ()definition for consistency.Fixes #1466