Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need new rpc command .. addnode <ip> remove .. does not remove from dns list as well as persistent list #79

Closed
toddfries opened this issue Jan 24, 2014 · 1 comment · Fixed by #341

Comments

@toddfries
Copy link
Contributor

104939 <@davec> ok so it's only looking in peers that we added
104950 <@davec> actually I think it's persistent peers in general
104952 < todd> the getpeerinfo rpc command can list all peers regardless of rpc list or dns list
105011 < todd> but the rpc 'addnode <ip> remove' cannot remove something from the dns list, only the rpc list
105036 <@davec> right    case delNodeMsg:
105036 < todd> so from what you said, 's/rpc list/persistent list/'
105036 <@davec>         found := false
105037 <@davec>         for e := state.persistentPeers.Front(); e != nil; e = e.Next() {
105044 <@davec> yep, that's wrong
105048 <@davec> ticket please
...
111339 <@davec> todd: oga just informed me that addnode is only *supposed* to work on persistent peers to be compatible with bitcoind
111410 <@davec> I rather agree that isn't very smart, but I guess we'll just provide an extension command that does it
111432 <@davec> not being able to remove any connection doesn't make sense

@davecgh
Copy link
Member

davecgh commented Apr 13, 2015

This will be implemented via the new node command once #341 is merged.

Roasbeef added a commit to Roasbeef/btcd that referenced this issue Apr 15, 2015
* Gives node operators full control of peer connectivity
* RPC adds ability to disconnect all matching non-persistent peers,
  remove persistent peers, and connect to peers making them either
  temporary or persistent.
jrick pushed a commit to jrick/btcd that referenced this issue Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants