Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mempool: Rejected transactions send incorrect subcommand. #436

Closed
davecgh opened this issue May 24, 2015 · 1 comment · Fixed by #437
Closed

mempool: Rejected transactions send incorrect subcommand. #436

davecgh opened this issue May 24, 2015 · 1 comment · Fixed by #437

Comments

@davecgh
Copy link
Member

davecgh commented May 24, 2015

Reported by @TheBlueMatt in IRC.

< BlueMatt> my bitcoind log has some reject messages that are apparently from btcd nodes - "Reject block code 64: orphan transaction size of XXXX is larger than max allowed size of XXXX bytes: hash..."
< BlueMatt> I'm hoping the bug is that the reject message should be a tx reject message, not a block reject message

The root cause of this is rejected transactions are currently setting the Cmd field of the reject message to block instead of the expected tx.
davecgh added a commit to davecgh/btcd that referenced this issue May 24, 2015
@davecgh
mempool: Correct cmd field for rejected txns.
56dedb7 
This commit corrects an issue where the reject message sent in response
to rejected transactions had the Cmd field set to "block" instead of
"tx".

Fixes btcsuite#436
davecgh added a commit to davecgh/btcd that referenced this issue May 24, 2015
@davecgh
mempool: Correct cmd field for rejected txns.
f79e53e 
This commit corrects an issue where the reject message sent in response
to rejected transactions had the Cmd field set to "block" instead of
"tx".

Fixes btcsuite#436.
@davecgh davecgh mentioned this issue May 24, 2015
Merged
@dajohi
Copy link
Member

dajohi commented May 26, 2015

Nice catch. OK.

davecgh added a commit to davecgh/btcd that referenced this issue May 26, 2015
@davecgh
mempool: Correct cmd field for rejected txns.
9350b93 
This commit corrects an issue where the reject message sent in response
to rejected transactions had the Cmd field set to "block" instead of
"tx".

Fixes btcsuite#436.
jcvernaleo pushed a commit to jcvernaleo/btcd that referenced this issue Nov 4, 2016
@dajohi @alexlyp
dcrctl: Set width to max in --terminal (btcsuite#436)
2bae2c0 
Fixes btcsuite#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mempool: Correct cmd field for rejected txns. davecgh/btcd
2 participants
@davecgh @dajohi