Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getrawtransactions includes confirmations=0 for unconfirmed tx #420

Closed
arnuschky opened this issue May 5, 2015 · 2 comments · Fixed by #422
Closed

getrawtransactions includes confirmations=0 for unconfirmed tx #420

arnuschky opened this issue May 5, 2015 · 2 comments · Fixed by #422

Comments

@arnuschky
Copy link

Bitcoin core omits the field confirmation in case the transaction in unconfirmed, while btcd includes it with value 0.

Similar to #416
@davecgh
Copy link
Member

davecgh commented May 6, 2015

Thanks. I'll push a PR for it in a bit. Similar to #416, missing versus 0 isn't really a big deal, but I'll change it for the sake of compatibility.

davecgh added a commit to davecgh/btcd that referenced this issue May 6, 2015
@davecgh
rpcserver: Omit empty getrawtransaction->confirmations.
f23be32 
This commit omits the confirmations field from the getrawtransactions
RPC result when there isn't one (i.e for current the tip).

Closes btcsuite#420.
davecgh added a commit to davecgh/btcd that referenced this issue May 6, 2015
@davecgh
rpcserver: Omit empty getrawtransaction->confirmations.
d880fee 
This commit omits the confirmations field from the getrawtransactions
RPC result when it's 0.

Closes btcsuite#420.
@davecgh davecgh mentioned this issue May 6, 2015
Merged
davecgh added a commit to davecgh/btcd that referenced this issue May 6, 2015
@davecgh
rpcserver: Omit empty getrawtransaction->confirmations.
443be45 
This commit omits the confirmations field from the getrawtransactions
RPC result when it's 0.

Closes btcsuite#420.
davecgh added a commit to davecgh/btcd that referenced this issue May 6, 2015
@davecgh
rpcserver: Omit empty getrawtransaction->confirmations.
a40058c 
This commit omits the confirmations field from the getrawtransactions
RPC result when it's 0.

Closes btcsuite#420.
@arnuschky
Copy link
Author

Confirmed working. Thanks.

cjepson added a commit to cjepson/btcd that referenced this issue Oct 13, 2016
@cjepson @alexlyp
Add voting version parsing function (btcsuite#420)
f26d1e4 
A voting version parsing function was added.  Vote versions are
uint32s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpcserver: Omit empty getrawtransaction->confirmations. davecgh/btcd
2 participants
@arnuschky @davecgh