Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite fails with react-dom 16.6.0 #56

Closed
papandreou opened this issue Jan 2, 2019 · 2 comments
Closed

Test suite fails with react-dom 16.6.0 #56

papandreou opened this issue Jan 2, 2019 · 2 comments

Comments

@papandreou
Copy link
Contributor

Upgrading react-dom from 16.5.2 to 16.6.0 makes 83 tests fail when running this part of the test suite:

mocha --require babel-core/register src/tests/general/*.spec.js

Bisecting in the react repo reveals that it broke when facebook/react#13902 was merged.
papandreou added a commit to papandreou/unexpected-react that referenced this issue Jan 2, 2019
@papandreou
Lock down react and react-dom to 16.5.2 to fix a bunch of failing tests
485b243 
Temporarily sidesteps bruderstein#56
@bruderstein
Copy link
Owner

Closing this as 6.0.0 supports 16.9 and above, so this is probably no longer an issue any more.

@papandreou
Copy link
Contributor Author

Awesome! Remember to push the new release 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bruderstein @papandreou