Skip to content

Commit

Permalink
feat: rate not available
Browse files Browse the repository at this point in the history
  • Loading branch information
brokeyourbike committed May 11, 2024
1 parent af9aab2 commit c6c3907
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 4 deletions.
11 changes: 11 additions & 0 deletions rate.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@ type MarketrateResponse struct {
ValueDate Time `json:"valueDate"`
}

func MarketrateNotAvailableError(err error) bool {
switch e := err.(type) {
case UnexpectedResponse:
switch e.Status {
case http.StatusNotFound, http.StatusBadRequest:
return true
}
}
return false
}

func (c *client) FetchMarketrate(ctx context.Context, params MarketrateParams) (data MarketrateResponse, err error) {
req, err := c.newRequest(ctx, http.MethodGet, "/fx/v1/marketrate", nil)
if err != nil {
Expand Down
25 changes: 21 additions & 4 deletions rate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@ import (
//go:embed testdata/marketrate-success.json
var marketrateSuccess []byte

//go:embed testdata/marketrate-fail.txt
var marketrateFail []byte
//go:embed testdata/marketrate-not-available.txt
var marketrateNotAvailable []byte

//go:embed testdata/marketrate-outside-trading-hours.txt
var marketrateOutsideTradingHours []byte

//go:embed testdata/negotiate-success.json
var negotiateSuccess []byte
Expand All @@ -38,6 +41,7 @@ func TestFetchMarketrate(t *testing.T) {

assert.Equal(t, 1.209602, got.MarketRate)
assert.Equal(t, "GBP/USD", got.Symbol)
assert.False(t, clearbank.MarketrateNotAvailableError(err))
}

func TestFetchMarketrate_RequestErr(t *testing.T) {
Expand All @@ -49,15 +53,28 @@ func TestFetchMarketrate_RequestErr(t *testing.T) {
require.Contains(t, err.Error(), "failed to create request")
}

func TestFetchMarketrate_Fail(t *testing.T) {
func TestFetchMarketrate_NotAvailable(t *testing.T) {
mockHttpClient := clearbank.NewMockHttpClient(t)
client := clearbank.NewClient("token", nil, clearbank.WithHTTPClient(mockHttpClient))

resp := &http.Response{StatusCode: 404, Body: io.NopCloser(bytes.NewReader(marketrateNotAvailable))}
mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(resp, nil).Once()

_, err := client.FetchMarketrate(context.TODO(), clearbank.MarketrateParams{FixedSide: clearbank.FixedSideBuy})
require.Error(t, err)
require.True(t, clearbank.MarketrateNotAvailableError(err))
}

func TestFetchMarketrate_OutsideTradingHours(t *testing.T) {
mockHttpClient := clearbank.NewMockHttpClient(t)
client := clearbank.NewClient("token", nil, clearbank.WithHTTPClient(mockHttpClient))

resp := &http.Response{StatusCode: 200, Body: io.NopCloser(bytes.NewReader(marketrateFail))}
resp := &http.Response{StatusCode: 400, Body: io.NopCloser(bytes.NewReader(marketrateOutsideTradingHours))}
mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(resp, nil).Once()

_, err := client.FetchMarketrate(context.TODO(), clearbank.MarketrateParams{FixedSide: clearbank.FixedSideBuy})
require.Error(t, err)
require.True(t, clearbank.MarketrateNotAvailableError(err))
}

func TestNegotiate(t *testing.T) {
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions testdata/marketrate-outside-trading-hours.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FX Quote is for outside stated trading times

0 comments on commit c6c3907

Please sign in to comment.