Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text measurement logic and implement proper text padding #88

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

wokalski
Copy link
Member

Fixes #74

We still have some other little text layout problems. They are described in #86 and #87.

This commit also updates the Flex version to our fork
Copy link
Member

@rauanmayemir rauanmayemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive work!

renderer-macos/lib/bindings/BriskStylableText.re Outdated Show resolved Hide resolved
renderer-macos/lib/stubs/BriskTextView.c Outdated Show resolved Hide resolved
core/lib/Layout.re Show resolved Hide resolved
core/lib/Layout.re Outdated Show resolved Hide resolved
examples/hacker-news/esy.json Outdated Show resolved Hide resolved
renderer-macos/lib/Brisk.re Outdated Show resolved Hide resolved
renderer-macos/lib/Styles.re Outdated Show resolved Hide resolved
renderer-macos/lib/stubs/BriskView.c Outdated Show resolved Hide resolved
renderer-macos/lib/stubs/BriskButton.c Show resolved Hide resolved
@wokalski
Copy link
Member Author

Fixed!

@rauanmayemir rauanmayemir merged commit c6c5e77 into master Mar 13, 2019
@rauanmayemir rauanmayemir deleted the bugfix/text-measurements branch March 13, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants