LPS-200853 Add jsPDF JavaScript to Portal #144302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-200853_jspdf 1 Successful Jobs:For more details click here. |
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#3847 (Took 1
ci:forwardattempt in 1 minute)Console
@thektan
@liferay-frontend
Original pull request comment:
https://liferay.atlassian.net/browse/LPS-200853
@bryceosterhaus originally sent: cgmonte#100
I just removed the
object-webchanges. I thought we could add these in so they could move forward with their story to add their feature https://liferay.atlassian.net/browse/LPS-201526. Even though the icons don't render (waiting for bubkoo/html-to-image#427 to be merged) and the only workaround is to use background images, at least that can be used for now.