Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI test for lowest supported runtime version of numpy #308

Merged
merged 7 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ jobs:
run: |
pytest --cov cyvcf2 --cov-report term-missing

# make sure to keep this numpy version in sync with setup.py
- name: Test with oldest numpy that we support
if: contains(fromJson('["3.7"]'), matrix.python-version)
run: |
pip install --force-reinstall --no-cache-dir 'numpy==1.16.0'
pytest --cov cyvcf2 --cov-report term-missing

- name: Test with newest available numpy
run: |
pip install -U numpy
pytest --cov cyvcf2 --cov-report term-missing

windows_build:
name: Run tests on Python windows-2022 MSYS2 UCRT64
runs-on: windows-2022
Expand Down Expand Up @@ -164,6 +176,11 @@ jobs:
run: |
pytest --cov cyvcf2 --cov-report term-missing

- name: Test with newest available numpy
run: |
pip install -U numpy
pytest --cov cyvcf2 --cov-report term-missing

sdist:
runs-on: ubuntu-22.04
strategy:
Expand Down Expand Up @@ -207,6 +224,11 @@ jobs:
run: |
pytest --import-mode importlib --cov cyvcf2 --cov-report term-missing

- name: Test with newest available numpy
run: |
pip install -U numpy
pytest --import-mode importlib --cov cyvcf2 --cov-report term-missing

- name: Upload sdist tarball
if: runner.os == 'Linux'
uses: actions/upload-artifact@v4
Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ def run(self):
],
),
python_requires=">=3.7",
install_requires=["numpy", "coloredlogs", "click"],
# make sure to keep this numpy version in sync with build.yml
install_requires=["numpy>=1.16.0", "coloredlogs", "click"],
include_package_data=True,
zip_safe=False,
cmdclass={
Expand Down