Implement INKEY with negative argument #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INKEY with a negative argument tests if the given fabgl virtual key (-arg) is currently held down. This is done with a keyboard state map maintained using an experimental mos_setkbvector OS call. (https://github.com/tomm/agon-mos/tree/mos_setkbvector)
|
Corresponding MOS PR: breakintoprogram/agon-mos#73 |
|
@breakintoprogram If there's interest in this PR (and the MOS prerequisite), I could modify it a little to use a 32-byte keyboard state map of boolean bitfields, instead of 256 bytes, which is a bit bloated. |
|
Hi @tomm I've ended up with a slightly different method. Whilst I'm closing this, I'll still credit you in the release notes as our ideas are essentially the same. |
breakintoprogram
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INKEY with a negative argument tests if the given fabgl virtual key is currently held down. This is done with a keyboard state map maintained using an experimental mos_setkbvector OS call. (https://github.com/tomm/agon-mos/tree/mos_setkbvector)