This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Integrate with the signature_generator.py script (for widevine).
#10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
suggested changes
Aug 30, 2017
| outDir = path.join(outDir, arch) | ||
| // sign for widevine | ||
| const wvExe = buildDir + '/Brave.exe' | ||
| const wvPlugin = buildDir + '/WidevineCdm/_platform_specific/' + widevineCdmArch + '/widevinecdmadapter.dll' |
There was a problem hiding this comment.
we will also need mac_x64 for widevinecdmadapter.plugin on MacOS
There was a problem hiding this comment.
macOS is hardcoded as mac_x64:
https://github.com/brave/browser-laptop/pull/10725/files#diff-bbf971d3d6ce3c0f91bf010517f5211aR55
bsclifton
force-pushed
the
widevine-0.18.x
branch
from
6b1bf77
to
f1fa2ec
Compare
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
Integrate with the `signature_generator.py` script (for widevine).
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
Integrate with the `signature_generator.py` script (for widevine).
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
Integrate with the `signature_generator.py` script (for widevine).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 3rd party file and will not be checked into source control
CI (such as Jenkins) can copy the file into place before building.
Auditors: @darkdh, @bbondy
Depends on brave/muon#283
Helping to fix #10449
NOTE: once accepted, we need to update the Jenkins job to copy this file into place before starting a CI build.
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests