-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Standalone Production config #134
base: master
Are you sure you want to change the base?
Conversation
… into add-nginx-forwarding
… into add-nginx-forwarding
Yes, that makes sense, but I prefer
I'd like to commit to nginx always being run b/c that makes the development and production environments as similar as possible (barring how brainlife.io deploys things). That is to say I think it's simpler to have 2 nginx configuration files and 1 env file then to have multiple docker compose files, but that solution while being simpler to me may not be the best path forward.
It was required as the health checks were failing when reaching out to
Yeah, I had some similar remarks about the run/build process, but I think it's helpful to keep in mind that this is not how ezbids is deployed on brainlife.io. Technically speaking, everything we've been doing has been "non-production" compared to how this project was originally scoped/intended to work. I agree and will be working today to streamline the launch/build process to better leverage:
When I requested my ssl certs I encrypted the keys, I'm not sure of a clever way around this within the nginx config. Before we think too much on this, could you try running the
No idea either, but I think consolidation is the word of the week for my branch. |
|
||
RUN npm install | ||
|
||
CMD [ "npm", "run", "build"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when I switch over to using the build
option it seems to break my application and make it unusable. Do the options build
and dev
that get used in this docker file correspond to this ->
Lines 4 to 8 in 8ddb0a0
"scripts": { | |
"dev": "vite --host", | |
"build": "vite build --base=/ezbids/", | |
"serve": "vite preview" | |
}, |
Really not sure what exactly is all going on here, but it feels like we're pretty close...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What further confuses me is what effect this vite config has, see ->
Lines 8 to 20 in 8ddb0a0
export default defineConfig({ | |
base: '/ezbids/', | |
plugins: [ | |
vue(), | |
Components({ | |
resolvers: [ElementPlusResolver()], | |
}), | |
ViteYaml(), | |
], | |
build: { | |
sourcemap: true, | |
}, | |
}); |
Is this at all related to the page refreshing?
Following the excellent work by Anthony I split the nginx into a proper config production which doesnt use the vite development server.
I still have a few open questions/remarks I want to discuss:
.env-example
and .gitignore the.env
file.Happy for your input.
Best,
Tim